Stories
Slash Boxes
Comments

SoylentNews is people

posted by on Monday March 06 2017, @10:59PM   Printer-friendly
from the post-bills-here dept.

Okay, we've all had our weekends and I at least am ready to jump back onto the coding horse. Refresh my memory of what we still have that's either properly broken or is otherwise behaving in an entirely unsatisfactory manner. I think Flat-mode links to individual comments are still broken. I know we need to replace the "noupdate" behavior with explicit "update" behavior. I'm thinking I can get the colors on "*NEW*" comments' subject bars brightened up so that you can ditch dimming and still have easy visual feedback if you like fairly quickly. I'm considering (nearly (can't do "N replies below Threshold)) precisely replicating Nested and adapting the old javascript to it if you care to run it. But what am I forgetting?

Discussion to a minimum here, please, so it doesn't distract from having an all-in-one-place list of things from this release that still need addressed.

 
This discussion has been archived. No new comments can be posted.
Display Options Threshold/Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
  • (Score: 2) by martyb on Wednesday March 08 2017, @03:31AM

    by martyb (76) Subscriber Badge on Wednesday March 08 2017, @03:31AM (#476305) Journal

    I ran into a problem with admin-to-user messaging when the message recipient receives messages from the *web*.

    Sent a multi-line test message to user who already had a message waiting.

    Message I sent:

    This is just a quick note to test admin-to-user messaging.
    This is on the second line.

    User sees text in RHS Slashbox:

    You have 1 new message waiting for you, and 9 old messages.

    User right-clicks on the "9 old messages" link and opens in new tab -- makes that tab current.

    User sees that message correctly displayed (YAY!)

    BUT... user deletes one of their old messages and is then presented with a different view of their messages; the view with checkboxes down the LHS.

    User now sees message as:

    Message from martyb:

    The message is not presented there, but that's okay... let's open that link and see the message...

    User right-clicks on my message to them and selects open in new tab (FWIW, Pale Moon v27)

    The only text of the message that the user sees on the new page is:

    This is on the second line.

    Huh. Where did the first line of the message go? Let's take a closer look!

    Right click on page, Select All, and then View Selection Source.

    User scrolls down to the message area and this is the HTML for the message:

        <div class="message_subject" <b="">Message from martyb:<br>
            sent by <b>SoylentNews Message System</b> on 2017.03.07 22:10
        </div>
        <div class="message_body" this="" is="" just="" a="" quick="" note="" to="" test="" admin-to-user="" messaging.="" <br="">
    This is on the second line.
        </div>

    Notice that the message_subject DIV has a strange tag starting string within the first div: <b=""

    That is strange, but it gets even more interesting.

    Look at the message_body div and notice how each of the words from the first line of the message appear as an attribute in that div (and now with a slightly different aberrant tag start, but with 'br instead of 'b', as follows: <br=""

    I don't know how long that has been there, but it is certainly reproducible, now.

    Many, MANY thanks to charon for playing guinea pig in helping me to reproduce and isolate this!

    --
    Wit is intellect, dancing.
    Starting Score:    1  point
    Karma-Bonus Modifier   +1  

    Total Score:   2