SoylentNews is people
SoylentNews is powered by your submissions, so send in your scoop. Only 17 submissions in the queue.
SoylentNews
While shutting down terminal windows to the SN servers this morning, one of them had the create table syntax for the comments table still on screen. I gave it a read through just because it was there and noticed that there wasn't an index for the opid (top level comment id for speeding up entire thread pulling) column. So I got some before numbers, added one, and ran some After tests. Heavily commented stories show a 50-150% pages-per-second speed increase in threaded views. Low hanging fruit FTW.
This discussion has been archived.
No new comments can be posted.
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
The last time I saw him he was walking down Lover's Lane holding his own hand.
-- Fred Allen
(Score: 3, Interesting) by The Mighty Buzzard on Wednesday January 09 2019, @02:04PM (18 children)
We might indeed be able to raise the 100 comment per page limit. It'll need some testing though.
My rights don't end where your fear begins.
(Score: 2) by zocalo on Wednesday January 09 2019, @02:12PM (7 children)
OK, I know there have been a few, but it's still pretty rare, but well done on spotting the missing index and taking the time to investigate further anyway. Faster load times = more time to read and comment!
UNIX? They're not even circumcised! Savages!
(Score: 2) by The Mighty Buzzard on Wednesday January 09 2019, @02:33PM (6 children)
Ten in the last thirty days. Two of them journal entries. That's not bad for us for a month heavy on holiday stuff.
My rights don't end where your fear begins.
(Score: 5, Funny) by Runaway1956 on Wednesday January 09 2019, @02:55PM (5 children)
I told you I'd be back to help you finish off the ham, and all those pies. But, did you listen? Noooooooooooo - you ate it all yourself. Now you're gonna complain about heavy? I don't wanna hear it. No sympathy from me that you have to turn sideways to get through the door.
(Score: 3, Touché) by The Mighty Buzzard on Wednesday January 09 2019, @03:11PM (4 children)
Man, I only put on five pounds between the big food holidays and having to eat more often for ten days of thrice-a-day antibiotics. Since I lost 35 pounds or so over the past year, I'm calling that a win.
My rights don't end where your fear begins.
(Score: 2) by Runaway1956 on Wednesday January 09 2019, @04:50PM (3 children)
Ugghhhh - hate those meds. And, they suck even more during the holiday season.
(Score: 2) by The Mighty Buzzard on Thursday January 10 2019, @04:09AM (2 children)
First time I've taken any since my 20s. They're just as annoying now as then. And the dipshit PA felt the need to prescribe me not one but two bloody decongestants after I told him the infection had my sinuses the clearest they had been in decades.
My rights don't end where your fear begins.
(Score: 2) by Runaway1956 on Thursday January 10 2019, @02:35PM (1 child)
Sinuses? Try scuba diving. They gave me hell through my teens. Guess I was 20, almost 21 when I took my diving lessons. We got out of the kiddy pool, and went on our first real dive, diddling around at around fifty feet. My ears popped, and I started running at the nose, head felt weird, and I headed to the surface. I was a god-awful mess for a couple hours, but I've never had sinus problems like I did in my teens. I suppose if I had ever described the experience to a nose-throat-and-ear specialist, he could have explained it. All I know is, life changed when I took up diving.
(Score: 2) by The Mighty Buzzard on Thursday January 10 2019, @05:13PM
Allergies have kept mine half plugged since my late teens. The sinus infection had them almost entirely clear. Weirdness doth abound in my general vicinity.
My rights don't end where your fear begins.
(Score: 3, Interesting) by takyon on Wednesday January 09 2019, @03:22PM (6 children)
Wouldn't this break existing URLs that link to specific pages?
[SIG] 10/28/2017: Soylent Upgrade v14 [soylentnews.org]
(Score: 2) by kazzie on Wednesday January 09 2019, @04:41PM
Are there (m)any of those?
I suppose one could only raise the bar on stories newer than $date to maintain compatibility.
(Score: 3, Informative) by martyb on Wednesday January 09 2019, @11:19PM
tl;dr: Depends on what you mean by 'existing'. A URL containing a page reference that you had saved away, say, as a bookmark could be a problem. But any accesses to different pages while a given page size is in effect should work fine.
Try it! Logged-in users can already set a preference for how many comments they want to see in a page:
See your new page size in effect.
Now, given all that... if you had previously saved a link to a comment externally that referred to a particular 'page' of comments, and then tried to open that link with a new page size in effect, then, well that won't work.
Wit is intellect, dancing.
(Score: 2) by The Mighty Buzzard on Thursday January 10 2019, @04:10AM (3 children)
If you're linking to specific pages, you're doing it wrong. How many are on a page is up to each individual user, so you can't have any idea what page a given comment is on.
My rights don't end where your fear begins.
(Score: 3, Interesting) by takyon on Thursday January 10 2019, @03:03PM (2 children)
So the comment permalinks have "page=N" on them. I changed my comments per page limit to 10 and it produces another number for the page. But both links display the exact same thing since they are actually looking at CID:
https://soylentnews.org/comments.pl?noupdate=1&sid=29494&page=2&cid=783383#commentwrap [soylentnews.org]
https://soylentnews.org/comments.pl?noupdate=1&sid=29494&page=6&cid=783383#commentwrap [soylentnews.org]
https://soylentnews.org/comments.pl?noupdate=1&sid=29494&page=190&cid=783383#commentwrap [soylentnews.org]
https://soylentnews.org/comments.pl?noupdate=1&sid=29494&page=1904249&cid=783383#commentwrap [soylentnews.org]
As you can see, even changing the page number to something absurd works.
So why is "page=N" even in the comment permalinks? Isn't it redundant linkcruft? It seems that we could remove that part.
[SIG] 10/28/2017: Soylent Upgrade v14 [soylentnews.org]
(Score: 2) by The Mighty Buzzard on Thursday January 10 2019, @05:16PM
Man, don't ask me today. I woke up late to db issues on both our bloody db servers and having to add 3-4 new sysadmins so people other than me can put out fires. My brain's fairly well toast.
My rights don't end where your fear begins.
(Score: 2) by The Mighty Buzzard on Friday January 11 2019, @12:19PM
Okay, now that I can read English again, I think that's "working as intended" though permalinks having a page number in them in the first place may not be. When you supply a cid it should show you only that comment and any below it, thread-wise. If, and only if, those comments add up to more than your max comments per page setting, they should paginate based on the comments immediately below the one whose cid was supplied. Invalid page numbers should show the first page.
My rights don't end where your fear begins.
(Score: 3, Funny) by RandomFactor on Wednesday January 09 2019, @10:54PM (1 child)
You.... You understood that.
В «Правде» нет известий, в «Известиях» нет правды
(Score: 2) by The Mighty Buzzard on Thursday January 10 2019, @04:13AM
His dumbassery ain't got nothin on some of the guys I grew up with.
My rights don't end where your fear begins.
(Score: 2) by Reziac on Thursday January 10 2019, @02:27AM
Noticeable improvement -- it's always been slow to redisplay post-moderating, and now it's not. So you fixed something. There, aren't you glad I broke it? :D
And there is no Alkibiades to come back and save us from ourselves.