Stories
Slash Boxes
Comments

SoylentNews is people

SoylentNews is powered by your submissions, so send in your scoop. Only 9 submissions in the queue.

Moderate^Post Is Now Moderate Then Post

posted by NCommander on Thursday April 10 2014, @05:40PM   Printer-friendly
from the if-we-accidently-implemented-something-we-promised-is-it-still-a-bug? dept.
I'm pleased to announce that moderate then post has now been implemented. In truth, its been implemented since the last major update due to a bug. Before releasing slashcode 14.04, I was experimenting with moderate^post code on dev, and the code was merged in with the basis that it would be enabled as part of the moderation reworks. Theoretically, this code should have been disabled. In actuality, I skewed a variable; the global that controls this functionality was not 100% properly implemented.

mrcoolbp noticed the bug today, and seeing as we needed a code change either way to properly fix it, I decided to roll this bit of the moderation rework out early. I'm not thrilled on squishing two bugs in production on the same day, and I'm going to be working with the dev team to get a rigorous QA plan put together (which will be posted here) before we do any more major updates to the site.

Until then, enjoy the new functionality.

NCommander adds: I'm giving this a one time bump on the main index as it was posted very late for US based users. We *really really* need a featured story feature.
 
This discussion has been archived. No new comments can be posted.
Moderate^Post Is Now Moderate Then Post | Log In/Create an Account | Top | 70 comments | Search Discussion
Display Options Threshold/Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.

  • (Score: 1) by iWantToKeepAnon on Thursday April 10 2014, @08:51PM

    by iWantToKeepAnon (686) on Thursday April 10 2014, @08:51PM (#29705) Homepage Journal

    HTTP for both tt-rss and soylentnews.org.

    I just started firefox with a new vanilla profile and the behavior is working as expected. It must be a combination of my noscript/greasemonkey/adblock/flashblock/ghostery/ paranoid settings/etc... that is doing it.

    Strange thing is while "debugging" this I found I can open a new tab, browse to soylentnews.org and get a login form; even though I am logged in. And then just reload and find my id there. So this isn't a rss-website 2 soylent-website issue. I was surprised that opening a new tab and going to soylentnews.org failed to find my user cookie.(??)

    Thanks for following up, but this is obviously on my end.

    --
    "Happy families are all alike; every unhappy family is unhappy in its own way." -- Anna Karenina by Leo Tolstoy

  • (Score: 2) by NCommander on Thursday April 10 2014, @09:07PM

    by NCommander (2) Subscriber Badge <michael@casadevall.pro> on Thursday April 10 2014, @09:07PM (#29714) Homepage Journal

    The odds are the user cookie is getting lost due to the redirect. I recommend you start your search there.

    --
    Still always moving

    • (Score: 1) by iWantToKeepAnon on Thursday April 10 2014, @09:27PM

      by iWantToKeepAnon (686) on Thursday April 10 2014, @09:27PM (#29726) Homepage Journal

      Culprit found, it is the add-on CsFire. If I disable it everything works as expected; it fixes the other site too. CsFire has been installed forever, I don't even remember when/why I got it.

      --
      "Happy families are all alike; every unhappy family is unhappy in its own way." -- Anna Karenina by Leo Tolstoy

      • (Score: 1) by iWantToKeepAnon on Thursday April 10 2014, @09:37PM

        by iWantToKeepAnon (686) on Thursday April 10 2014, @09:37PM (#29729) Homepage Journal

        I see in the logs where it strips the cookie because the From address is "about" and the Destination is soylentnews.org. I added a rule for From (blank) To soylentnews.org Decision ACCEPT. That seems to make it happy and accept all cookies, even the first/initial one. The follow up reloads were ok because they were From soylentnews.org To soylentnews.org.

        CsFire claims to protect you from Cross-Site Request Forgery (CSRF) attacks. Websites that make requests to other sites can be used to track the user and CsFire claims to stop that too.

        Just FYI, thanks for your time!

        --
        "Happy families are all alike; every unhappy family is unhappy in its own way." -- Anna Karenina by Leo Tolstoy