Stories
Slash Boxes
Comments

SoylentNews is people

Meta
posted by janrinok on Tuesday June 14 2016, @01:23PM   Printer-friendly
from the like-maple-syrup dept.

So, the Islamic Terrorist Opens Fire on Florida Nightclub; 50 Killed, 53 Wounded story is up over 400 comments and loading slower than hell. We finally managed to find ourselves a limit to comments under the current code. There's a fix going to be coming in the upcoming site update but for now there are two workarounds; take your pick.

  1. Change your comment view mode to Nested or Flat.
  2. Change Comment Limit under Preferences to five to ten.

The latter solution gives you 5-10 root level comments and all their children not 5-10 comments total. It also allows you to keep using the javascript expand/collapse buttons if you were.


Original Submission

Related Stories

Breaking News: Islamic Terrorist Opens Fire on Florida Nightclub; 50 Killed, 53 Wounded 434 comments

A suspected Islamic terrorist opened fire at a gay nightclub in Florida, killing 50 people and wounding another 53 before he was killed by police. While authorities continue to investigate to determine whether this man had ties to ISIS, the terror organization has not been quiet in praising the attack. This comes three days after ISIS announced they would attack somewhere in Florida. Today's attack marks the largest act of terrorism on US soil since 9/11.

takyon: The gunman reportedly called 911 emergency services to pledge allegiance to ISIS. The President will hold a briefing momentarily. Compare this article to the original submission.


Original Submission   Late submission by physicsmajor

This discussion has been archived. No new comments can be posted.
Display Options Threshold/Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.
  • (Score: 2) by jdavidb on Tuesday June 14 2016, @01:40PM

    by jdavidb (5690) on Tuesday June 14 2016, @01:40PM (#359879) Homepage Journal

    Being an old school dinosaur, I still browse in Nested mode, so I guess I wasn't subject to this. I always thought Nested mode was pretty impressive, back in the day, and I haven't taken more than a quick look at the new mode Rehash introduces. I'm sure that's a shame because I'm sure a lot of hard and thoughtful work went into making something there most people would like, but I got so used to Nested being good enough I just never tried it. In fact after all the pressure over at the other site to go to new modes it was refreshing when I got here to have Nested available and be able to stick with it without every so often being randomly "upgraded" and having to hunt around for what bit to flip to get back to the way I've browsed for 1.5 decades.

    --
    ⓋⒶ☮✝🕊 Secession is the right of all sentient beings
  • (Score: 3, Funny) by Gaaark on Tuesday June 14 2016, @01:50PM

    by Gaaark (41) on Tuesday June 14 2016, @01:50PM (#359886) Journal

    the big times just happen, when Soylentnews just soyled ITSELF? :)

    "Why, i remember when SoylentNews was just this little rinky-dink operation that had to travel uphill bothways in a freaking snow storm, and now it's an old operation, sitting around soyling itself and needing CPR once in a while.... ahhh good times, good times.....

    ..... hey, you kids... get off my damn lawn!"

    --
    --- Please remind me if I haven't been civil to you: I'm channeling MDC. ---Gaaark 2.0 ---
    • (Score: 0) by Anonymous Coward on Tuesday June 14 2016, @03:56PM

      by Anonymous Coward on Tuesday June 14 2016, @03:56PM (#359958)

      Historic event coupled with an ongoing meta narrative.

      Was actually pleased even unpopular views weren't voiced in an polemic way.

      That unfortunately won't last if Soylent gets much bigger.

      • (Score: 2) by bob_super on Tuesday June 14 2016, @07:27PM

        by bob_super (1357) on Tuesday June 14 2016, @07:27PM (#360105)

        When I saw that it was over 200 comments, I decided to stay away from that one.
        Considering how the perception of the shooter has changed in the last 48 hours, I might get a truckload of popcorn and read the whole thing in a few weeks, just as an educative experience.

  • (Score: 2) by Username on Tuesday June 14 2016, @03:48PM

    by Username (4557) on Tuesday June 14 2016, @03:48PM (#359954)

    s = seconds

    Flat 7s first page
    Improved Threaded 5s
    Nested 7s first page
    No Comments 1s
    Threaded 5s

    Based on Opera 12.15 page load timer.

    • (Score: 2) by The Mighty Buzzard on Tuesday June 14 2016, @04:01PM

      Difficult to really test. Page render times on the live site doesn't take into account server load or whether the db had all the comments it was asked for already cached in ram or had to go to disk for them. Also, try it with max comments set to say 100 and you'll see a huge speed increase between Threaded and Nested and between Nested and Flat.

      --
      My rights don't end where your fear begins.
      • (Score: 2) by Username on Tuesday June 14 2016, @04:21PM

        by Username (4557) on Tuesday June 14 2016, @04:21PM (#359971)

        Eh, I think I have all the default settings, too lazy to change unless there is -1 I wanna see. So its choking on the database requests? Maybe if a thread is over X amount of posts make it a static page on a ram disk and have the script update that instead of db?

        • (Score: 2) by The Mighty Buzzard on Tuesday June 14 2016, @04:43PM

          Interesting idea. It wouldn't work that easily because many logged in users have customized their score, visibility, and number of comments per page settings and even ACs can customize a little bit via the drop-down menus, so we'd need potentially thousands of cached versions for each story. I recently tried just using a memory cache of the same-for-all-users db results but didn't see any detectable improvement.

          Nah, what it's choking on currently is processing the templates necessary to generate a laid out comment for each of potentially hundreds of comments. With Threaded and your comments per page setting at max you see every comment for the linked story above on the first page, all four hundred plus of them. And it takes over a minute to render. Me, I'm currently thinking it'd be faster to do away with templates for comments and do the layout as hardcoded as possible.

          --
          My rights don't end where your fear begins.
          • (Score: 0) by Anonymous Coward on Tuesday June 14 2016, @09:31PM

            by Anonymous Coward on Tuesday June 14 2016, @09:31PM (#360178)

            That's the kind of thing that could be fixed with smart javascript.
            Let the posts be a static file and use javascript to apply the filters to hide/collapse based on the score.
            Might even be able to do it without javascript, just really clever CSS.

            • (Score: 2) by The Mighty Buzzard on Wednesday June 15 2016, @12:53AM

              by The Mighty Buzzard (18) Subscriber Badge <themightybuzzard@proton.me> on Wednesday June 15 2016, @12:53AM (#360293) Homepage Journal

              It'd have to be some extremely clever css. Collapsing comments below score N we can do easily through css, and already are doing so on dev, but the numeric comparison has to be done server-side unless we want to use javascript, which is a non-starter. House rule: everything has to run correctly without javascript turned on. Too many of the community block it.

              --
              My rights don't end where your fear begins.
          • (Score: 2) by Username on Tuesday June 14 2016, @10:38PM

            by Username (4557) on Tuesday June 14 2016, @10:38PM (#360216)

            Yeah could have one large template and load separate stylesheets for each level of score, comments etc. Offload it to the browser.

            • (Score: 2) by The Mighty Buzzard on Wednesday June 15 2016, @12:47AM

              by The Mighty Buzzard (18) Subscriber Badge <themightybuzzard@proton.me> on Wednesday June 15 2016, @12:47AM (#360288) Homepage Journal

              Gravis and I talked about just that a month or so ago in IRC but there are a few problems that keep it from being possible. There's processing that has to be done to the raw score and either perl has to do it or javascript does. We are moving the collapsed/non-collapsed state out to CSS but the low-hanging fruit that paulej72 and I could find is already gone.

              --
              My rights don't end where your fear begins.
  • (Score: 2) by takyon on Tuesday June 14 2016, @07:53PM

    by takyon (881) <{takyon} {at} {soylentnews.org}> on Tuesday June 14 2016, @07:53PM (#360121) Journal

    Try loading my userpage. Maybe if enough of you do it, the site will crash.

    martyb is investigating the cause.

    --
    [SIG] 10/28/2017: Soylent Upgrade v14 [soylentnews.org]
    • (Score: 0) by Anonymous Coward on Wednesday June 15 2016, @09:06AM

      by Anonymous Coward on Wednesday June 15 2016, @09:06AM (#360443)

      Some pagination wouldn't go amiss there..

  • (Score: 2) by darkfeline on Tuesday June 14 2016, @08:20PM

    by darkfeline (1030) on Tuesday June 14 2016, @08:20PM (#360144) Homepage

    The post is light on details; as SN has a higher proportion of programmers and generally intelligent people, we can afford to be more informative.

    From what I can tell:

    - Nested shows all comments fully in a tree
    - Threaded shows in a tree only root comment and comments that hit the breakthrough score fully, non-root comments below breakthrough are collapsed links
    - Improved Threaded is Threaded with Javascript for expanding and collapsing

    I'm guessing the issue here is that Improved Threaded needs to be made more smart w.r.t. many comments.

    --
    Join the SDF Public Access UNIX System today!
    • (Score: 2) by The Mighty Buzzard on Tuesday June 14 2016, @08:38PM

      Nah, it's just that running the templates for each comment adds up after a hundred or so and gets downright sad by four hundred. Nested isn't really any faster than Threaded and Improved Threaded is the same speed as Threaded as far as our servers are concerned.

      --
      My rights don't end where your fear begins.
    • (Score: 2, Funny) by Anonymous Coward on Tuesday June 14 2016, @08:43PM

      by Anonymous Coward on Tuesday June 14 2016, @08:43PM (#360158)

      SN has a higher proportion of programmers and generally intelligent people

      Too bad they never post.

      • (Score: 2) by ThePhilips on Wednesday June 15 2016, @08:45AM

        by ThePhilips (5677) on Wednesday June 15 2016, @08:45AM (#360440)

        They are too busy ranting the fine legal points about the Hillary's e-mail snafu.

        P.S. Being intelligent is not the same as having sane priorities.