SoylentNews is people
SoylentNews
Okay, we've all had our weekends and I at least am ready to jump back onto the coding horse. Refresh my memory of what we still have that's either properly broken or is otherwise behaving in an entirely unsatisfactory manner. I think Flat-mode links to individual comments are still broken. I know we need to replace the "noupdate" behavior with explicit "update" behavior. I'm thinking I can get the colors on "*NEW*" comments' subject bars brightened up so that you can ditch dimming and still have easy visual feedback if you like fairly quickly. I'm considering (nearly (can't do "N replies below Threshold)) precisely replicating Nested and adapting the old javascript to it if you care to run it. But what am I forgetting?
Discussion to a minimum here, please, so it doesn't distract from having an all-in-one-place list of things from this release that still need addressed.
(Score: 1, Interesting) by Anonymous Coward on Tuesday March 07 2017, @02:01AM (2 children)
You said that much of what RedBear mentioned "is on the slate to be tweaked or entirely redone." (for reference: https://soylentnews.org/comments.pl?sid=18216&cid=473029). [soylentnews.org]
After looking through your short-term posting history, I came across this post of yours: https://soylentnews.org/comments.pl?sid=18216&cid=473288 [soylentnews.org]
I'm not sure if it is related, but when I click that post's id or the parent link I get this error:
We can't find a comment with that ID (473288) in this discussion (18216). If this comment was posted moments ago, please wait 60 seconds for it to appear. Otherwise, if you got here through a link generated by SoylentNews, please report this as a bug. But if you got here thanks to a silly user's comment text or journal entry or something, or from an external site, this link is just invalid -- sorry.
The error seems to only happen in Threaded-TNG and Threaded-TOS because Flat works fine. I'm an AC running Linux Mint and the same error happens in Firefox, Qupzilla, and Chromium.
(Score: 2) by martyb on Tuesday March 07 2017, @01:33PM (1 child)
This one is somewhat nasty.
The comment IS in the discussion, but on page *2* at the moment (for me at least; TNG -1, -1, Oldest first), 100 comments per page)... but all it takes is a bunch of replies to earlier comments to possibly push the comment onto a still later page. IOW, a page number may be meaningful only for a limited period of time, and for a particular user.
I can adjust my preferences to set my page size to, say, 20 comments. You might still run with the default (100 comments per page). I post a link to a comment that appears on MY page 3, which you click and discover that you only have 1 page. :(
It may be even worse than that... depending on what one's sort order is: "Oldest First" or "Newest First"... what was once on page 3 (a very recent post appearing at the end of a discussion when viewed as "Oldest First") may now appear on page 1 when sorted "Newest First". :( :(
It seems to me that page number is something that *IS* important to the comment display code, but should not be presented in the URL used to access it?
Hypothesis: Need a function that, given an SID, a CID, Threshold, Breakthrough, display Mode, and a Sort order, returns... the number of the page on which it appears and, since one had to basically compute all this in order to compute that page number, the CIDs of the TLCs for that page.(TLC == Top Level Comment - i.e. a comment that has no parent comment as it is a Reply to the story itself.)
Note: I woke not long ago, so take the forgoing with the proverbial portion of salt.
Wit is intellect, dancing.
(Score: 2) by paulej72 on Tuesday March 07 2017, @02:35PM
We fixed this for flat, but need to fix it for Threaded. The issue is we should be ignoring page when cid is set. We did not think through all of the issues that this would cause, but we ill get it fixed.
Team Leader for SN Development