Stories
Slash Boxes
Comments

SoylentNews is people

Moderate^Post Is Now Moderate Then Post

posted by NCommander on Thursday April 10 2014, @05:40PM   Printer-friendly
from the if-we-accidently-implemented-something-we-promised-is-it-still-a-bug? dept.
I'm pleased to announce that moderate then post has now been implemented. In truth, its been implemented since the last major update due to a bug. Before releasing slashcode 14.04, I was experimenting with moderate^post code on dev, and the code was merged in with the basis that it would be enabled as part of the moderation reworks. Theoretically, this code should have been disabled. In actuality, I skewed a variable; the global that controls this functionality was not 100% properly implemented.

mrcoolbp noticed the bug today, and seeing as we needed a code change either way to properly fix it, I decided to roll this bit of the moderation rework out early. I'm not thrilled on squishing two bugs in production on the same day, and I'm going to be working with the dev team to get a rigorous QA plan put together (which will be posted here) before we do any more major updates to the site.

Until then, enjoy the new functionality.

NCommander adds: I'm giving this a one time bump on the main index as it was posted very late for US based users. We *really really* need a featured story feature.
 
This discussion has been archived. No new comments can be posted.
Moderate^Post Is Now Moderate Then Post | Log In/Create an Account | Top | 70 comments | Search Discussion
Display Options Threshold/Breakthrough Mark All as Read Mark All as Unread
The Fine Print: The following comments are owned by whoever posted them. We are not responsible for them in any way.

  • (Score: 2) by Adrian Harvey on Thursday April 10 2014, @06:18AM

    by Adrian Harvey (222) on Thursday April 10 2014, @06:18AM (#29298)

    Thanks for explaining that, I hadn't worked out why my phone kept having to re-authenticate. Now I know it was every time there was a wifi/mobile data switch! And even better I can fix it myself in preferences.

    By the way, in your great bug hunt, I presume from this version of Slashcode sends a proper auth cookie of some sort, as opposed to the old version which used to send you a cookie with a base-64 encoded copy of your own password...

    Starting Score:    1  point
    Karma-Bonus Modifier   +1  
    Total Score:   2  

  • (Score: 2) by NCommander on Thursday April 10 2014, @04:49PM

    by NCommander (2) Subscriber Badge <michael@casadevall.pro> on Thursday April 10 2014, @04:49PM (#29553) Homepage Journal

    I don't know on the cookie front, but we haven't changed anything in this regard.

    We could fix this, or we could just go SSL by default as the quick fix. I'm liking that second one more :-)

    --
    Still always moving

    • (Score: 2) by egcagrac0 on Thursday April 10 2014, @07:02PM

      by egcagrac0 (2705) on Thursday April 10 2014, @07:02PM (#29644)

      Please don't go for the quick fix for the sake of expedience.

      Strive to apply the Right fix to either the quick-to-fix problems, or the Important problems.

      I'm not above picking low-hanging fruit, but doing it the Right Way is a Good Thing. ("Fix it once, properly, and be done.")

      It may well be that your quick fix is the Right fix, but it should be done because it's Right, not because it's quick.

      • (Score: 2) by NCommander on Thursday April 10 2014, @08:23PM

        by NCommander (2) Subscriber Badge <michael@casadevall.pro> on Thursday April 10 2014, @08:23PM (#29688) Homepage Journal

        I generally agree with this, but the amount of work to architect in thread ids should not be under-estimated, and I'm not completely convinced that this is a good idea. Moderate then post was what was discussed, and it solves the primary problem of creating a chilling effect on comments.

        --
        Still always moving

  • (Score: 1) by paulej72 on Thursday April 10 2014, @07:51PM

    by paulej72 (58) on Thursday April 10 2014, @07:51PM (#29673) Journal

    I have noticed that I have to re log in after we we restart apache and kick varinsh. So the cookie may be getting invalidated as well by these server side changes.

    Not 100% sure on this, but it is possibly a factor.

    --
    Team Leader for SN Development